Skip to content

SNOW-2303618: fix DataFrame.limit() fail if there is parameter binding in the executed SQL.#3780

Merged
sfc-gh-yuwang merged 6 commits into
mainfrom
SNOW-2303618
Sep 18, 2025
Merged

SNOW-2303618: fix DataFrame.limit() fail if there is parameter binding in the executed SQL.#3780
sfc-gh-yuwang merged 6 commits into
mainfrom
SNOW-2303618

Conversation

@sfc-gh-yuwang

@sfc-gh-yuwang sfc-gh-yuwang commented Sep 15, 2025

Copy link
Copy Markdown
Collaborator
  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-NNNNNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
    • If adding any arguments to public Snowpark APIs or creating new public Snowpark APIs, I acknowledge that I have ensured my changes include AST support. Follow the link for more information: AST Support Guidelines
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

Comment thread tests/integ/test_dataframe.py
@sfc-gh-yuwang

Copy link
Copy Markdown
Collaborator Author

the if else clause in schema_utils.py is removed because that is meant to make sure backwards compatible with connector 2.x, since we are now requiring 3.x connector as minimun, that is not necessary anymore

@sfc-gh-yuwang sfc-gh-yuwang merged commit 3e9305e into main Sep 18, 2025
28 of 29 checks passed
@sfc-gh-yuwang sfc-gh-yuwang deleted the SNOW-2303618 branch September 18, 2025 22:24
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants